huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1454364047
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void close() throws IOException {
+ super.close();
Review Comment:
look here:
https://github.com/apache/iceberg/blob/31d18f51b9e8590f7ca316463b080bd1153e8f9e/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/TableLoader.java#L138
Because of this, I think BaseMetastoreCatalog should keep Closeable to limit
the behavior of subclasses, because the metricsReporter in BaseMetastoreCatalog
must be released when the catalog is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
