mas-chen commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462566583
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##########
@@ -367,6 +382,8 @@ public void testSpecificSnapshotTimestamp() throws
Exception {
List<Row> result3 = waitForResult(iter, 2);
TestHelpers.assertRecords(result3, batch3,
tableResource.table().schema());
+
+ assertThatIcebergEnumeratorMetricsExist();
Review Comment:
Yeah polling is a challenge. I can do fine-grained units to have better
control on when it is invoked. However, I don't think it is possible to assert
on a distinct value
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##########
@@ -367,6 +382,8 @@ public void testSpecificSnapshotTimestamp() throws
Exception {
List<Row> result3 = waitForResult(iter, 2);
TestHelpers.assertRecords(result3, batch3,
tableResource.table().schema());
+
+ assertThatIcebergEnumeratorMetricsExist();
Review Comment:
Yeah polling is a challenge. I can do fine-grained unit tests to have better
control on when it is invoked. However, I don't think it is possible to assert
on a distinct value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
