mas-chen commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464155134
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##########
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous {
+ public static final InMemoryReporter METRIC_REPORTER =
InMemoryReporter.create();
+
@ClassRule
public static final MiniClusterWithClientResource MINI_CLUSTER_RESOURCE =
- MiniClusterResource.createWithClassloaderCheckDisabled();
+ MiniClusterResource.createWithClassloaderCheckDisabled(METRIC_REPORTER);
Review Comment:
@pvary @stevenzwu @nastra I'm fine with that and I can volunteer to migrate
this class to JUnit5 after the PR is merged. I am limited in my bandwidth this
week, so I can address it next week, while I would like these metrics to land
in the upcoming iceberg release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
