pvary commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462735668
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SplitAssigner.java:
##########
@@ -115,4 +115,7 @@ default void onCompletedSplits(Collection<String>
completedSplitIds) {}
* snapshots and splits, which defeats the purpose of throttling.
*/
int pendingSplitCount();
+
+ /** Pending records count */
Review Comment:
This is a public facing interface.
What about:
```
/** Pending records count. Could be an estimation if exact numbersare not
available*/
```
I am not comfortable stating one thing in the comments/docs and doing other
things in the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
