nastra commented on code in PR #9675:
URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484171305
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -83,6 +88,10 @@ case class RewriteViewCommands(spark: SparkSession) extends
Rule[LogicalPlan] wi
catalogManager.v1SessionCatalog.isTempView(nameParts)
}
+ private def isTempFunction(ident: FunctionIdentifier): Boolean = {
Review Comment:
there's currently no other place that would use this (and it also depends on
the `catalogManager`), so I left it here (similar to `isTempView(..)` a few
lines above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
