rdblue commented on code in PR #9675:
URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501265639
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -149,4 +163,20 @@ case class RewriteViewCommands(spark: SparkSession)
extends Rule[LogicalPlan] wi
None
}
}
+
+ /**
+ * Collect the names of all temporary functions.
+ */
+ private def collectTemporaryFunctions(child: LogicalPlan): Seq[String] = {
+ val tempFunctions = new mutable.HashSet[String]()
+
child.resolveExpressionsWithPruning(_.containsAnyPattern(UNRESOLVED_FUNCTION)) {
+ case f @ UnresolvedFunction(nameParts, _, _, _, _) if
isTempFunction(nameParts) =>
+ tempFunctions += nameParts.asFunctionIdentifier.funcName
Review Comment:
I don't think it is a good idea to convert to a function identifier. We can
just convert the name parts directly to a string. Plus, we know that if
`isTempFunction` is true then it is only one part anyway, so the extra
conversion doesn't help make this safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
