rdblue commented on code in PR #9675:
URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501266819
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -471,6 +471,39 @@ public void readFromViewReferencingGlobalTempView() throws
NoSuchTableException
.hasMessageContaining("cannot be found");
}
+ @Test
+ public void readFromViewReferencingTempFunction() throws
NoSuchTableException {
+ insertRows(10);
+ String viewName = viewName("viewReferencingTempFunction");
+ String functionName = "test_avg";
+ String sql = String.format("SELECT %s(id) FROM %s", functionName,
tableName);
+ sql(
+ "CREATE TEMPORARY FUNCTION %s AS
'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage'",
+ functionName);
+
+ ViewCatalog viewCatalog = viewCatalog();
+ Schema schema = tableCatalog().loadTable(TableIdentifier.of(NAMESPACE,
tableName)).schema();
+
+ // it wouldn't be possible to reference a TEMP FUNCTION if the view had
been created via SQL,
+ // but this can't be prevented when using the API directly
+ viewCatalog
+ .buildView(TableIdentifier.of(NAMESPACE, viewName))
+ .withQuery("spark", sql)
+ .withDefaultNamespace(NAMESPACE)
+ .withDefaultCatalog(catalogName)
+ .withSchema(schema)
+ .create();
+
+ assertThat(sql(sql)).hasSize(1).containsExactly(row(5.5));
+
+ // reading from a view that references a TEMP FUNCTION shouldn't be
possible
+ assertThatThrownBy(() -> sql("SELECT * FROM %s", viewName))
+ .isInstanceOf(AnalysisException.class)
+ .hasMessageContaining("The function")
Review Comment:
I'm not sure if it is easy to fix, but this message could also be improved
using our standard format: `Cannot load function: %s` where `%s` is the
fully-qualified name, including the catalog name so that it is clear that it
was resolved to a catalog function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
