nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497750920
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java:
##########
@@ -76,10 +73,9 @@ public static void stopSpark() {
public void testCallWithPositionalArgs() throws ParseException {
CallStatement call =
(CallStatement) parser.parsePlan("CALL c.n.func(1, '2', 3L, true,
1.0D, 9.0e1, 900e-1BD)");
- Assert.assertEquals(
- ImmutableList.of("c", "n", "func"),
JavaConverters.seqAsJavaList(call.name()));
+
assertThat(seqAsJavaList(call.name())).hasSameElementsAs(ImmutableList.of("c",
"n", "func"));
Review Comment:
```suggestion
assertThat(seqAsJavaList(call.name())).containsExactly("c", "n", "func");
```
please also update the other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
