nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497783653
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSnapshotTableProcedure.java:
##########
@@ -85,15 +82,17 @@ public void testSnapshotWithProperties() throws IOException
{
"CALL %s.system.snapshot(source_table => '%s', table => '%s',
properties => map('foo','bar'))",
catalogName, sourceName, tableName);
- Assert.assertEquals("Should have added one file", 1L, result);
+ assertThat(result).as("Should have added one file").isEqualTo(1L);
Table createdTable = validationCatalog.loadTable(tableIdent);
String tableLocation = createdTable.location();
- Assert.assertNotEquals("Table should not have the original location",
location, tableLocation);
+ assertThat(tableLocation)
+ .as("Table should not have the original location")
+ .isNotEqualTo(location);
Map<String, String> props = createdTable.properties();
- Assert.assertEquals("Should have extra property set", "bar",
props.get("foo"));
+ assertThat(props.get("foo")).as("Should have extra property
set").isEqualTo("bar");
Review Comment:
please use `containsEntry()` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
