nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497756824
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCreateChangelogViewProcedure.java:
##########
@@ -428,15 +425,15 @@ public void testNetChangesWithRemoveCarryOvers() {
sql("select * from %s order by _change_ordinal, data", viewName));
}
- @Test
+ @TestTemplate
public void testNetChangesWithComputeUpdates() {
createTableWithTwoColumns();
- assertThrows(
- "Should fail because net_changes is not supported with computing
updates",
- IllegalArgumentException.class,
- () ->
- sql(
- "CALL %s.system.create_changelog_view(table => '%s',
identifier_columns => array('id'), net_changes => true)",
- catalogName, tableName));
+ Assertions.assertThatThrownBy(
Review Comment:
```suggestion
assertThatThrownBy(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
