nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497785620
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSnapshotTableProcedure.java:
##########
@@ -183,14 +183,15 @@ public void testSnapshotWithConflictingProps() throws
IOException {
Table table = validationCatalog.loadTable(tableIdent);
Map<String, String> props = table.properties();
- Assert.assertEquals("Should override user value", "true",
props.get("snapshot"));
- Assert.assertEquals(
- "Should override user value", "false",
props.get(TableProperties.GC_ENABLED));
+ assertThat(props.get("snapshot")).as("Should override user
value").isEqualTo("true");
+ assertThat(props.get(TableProperties.GC_ENABLED))
Review Comment:
this should also use `containsEntry()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
