amogh-jahagirdar commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1694308507
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -515,6 +523,8 @@ private static String sanitize(Type type, Object value,
long now, int today) {
return "(time)";
case TIMESTAMP:
return sanitizeTimestamp((long) value, now);
+ case TIMESTAMP_NANO:
Review Comment:
I think I'd like to double check if sanitizing the `TIMESTAMP_NANO` as
microseconds is OK?
Looking at the test cases it seems fine for addressing the existing cases
but those are all coarser grained time differences (like 90 minutes, or
"about-now" within 5 minutes). But are there cases where the sanitized string
need to represent something more granular for nanosecond timestamps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
