rdblue commented on code in PR #9008: URL: https://github.com/apache/iceberg/pull/9008#discussion_r1697462451
########## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ########## @@ -515,6 +548,18 @@ public <T> Literal<T> to(Type type) { return (Literal<T>) new TimestampLiteral(timestampMicros); } + case TIMESTAMP_NANO: + if (((Types.TimestampNanoType) type).shouldAdjustToUTC()) { + return (Literal<T>) new TimestampNanoLiteral(DateTimeUtil.isoTimestampToNanos(value())); Review Comment: Why does this use `DateTimeUtil` but the `else` block does not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org