rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1697462920


##########
api/src/main/java/org/apache/iceberg/transforms/Bucket.java:
##########
@@ -214,6 +217,20 @@ protected int hash(Long value) {
     }
   }
 
+  // In order to bucket TimestampNano the same as Timestamp, we divide these 
values by 1000.

Review Comment:
   We need to make sure this makes it into the spec.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to