bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695768314
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##########
@@ -65,5 +66,15 @@ boolean isTerminated() {
void terminate() {
terminated = true;
+
+ try {
+ join(60_000);
Review Comment:
Thinking out loud here, I'm considering using the consumer group generation
ID to fence "zombie" coordinators, similar to how Kafka implements zombie
fencing. For example, store the generation ID when we start the coordinator and
assert that generation ID matches the current before we commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
