fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696035086
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##########
@@ -65,5 +66,15 @@ boolean isTerminated() {
void terminate() {
terminated = true;
+
+ try {
+ join(60_000);
Review Comment:
Here's what we could do in kafka-connect-iceberg if iceberg supported
conditional commits:
https://github.com/apache/iceberg/pull/10812/commits/4bff04104f50e23bc6dd387ffb32450ae4826490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
