aokolnychyi commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1792838808
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -230,27 +232,20 @@ SnapshotSummary.Builder
buildSummary(Iterable<ManifestFile> manifests) {
*
* @param manifests a set of filtered manifests
*/
- @SuppressWarnings("CollectionUndefinedEquality")
private void validateRequiredDeletes(ManifestFile... manifests) {
if (failMissingDeletePaths) {
- CharSequenceSet deletedFiles = deletedFiles(manifests);
- ValidationException.check(
- deletedFiles.containsAll(deletePaths),
- "Missing required files to delete: %s",
- COMMA.join(Iterables.filter(deletePaths, path ->
!deletedFiles.contains(path))));
+ deletedFiles(manifests).validateRequiredDeletes(filesToDelete);
Review Comment:
What if we have a path-only delete that is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
