nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793049678
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -71,6 +72,7 @@ public String partition() {
private final PartitionSet deleteFilePartitions;
private final PartitionSet dropPartitions;
private final CharSequenceSet deletePaths = CharSequenceSet.empty();
+ private final FilesToDeleteHolder filesToDelete = new FilesToDeleteHolder();
private Expression deleteExpression = Expressions.alwaysFalse();
private long minSequenceNumber = 0;
private boolean hasPathOnlyDeletes = false;
Review Comment:
yep we can surely remove `hasPathOnlyDeletes`. I was trying to keep changes
to an absolute minimum in this class and leave such non-essential refactorings
out of the diff but I'm fine doing it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
