nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793058000
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -81,8 +83,8 @@ abstract class MergingSnapshotProducer<ThisT> extends
SnapshotProducer<ThisT> {
// update data
private final Map<PartitionSpec, List<DataFile>> newDataFilesBySpec =
Maps.newHashMap();
- private final CharSequenceSet newDataFilePaths = CharSequenceSet.empty();
- private final CharSequenceSet newDeleteFilePaths = CharSequenceSet.empty();
+ private final DataFileSet newDataFiles = DataFileSet.create();
+ private final DeleteFileSet newDeleteFiles = DeleteFileSet.create();
Review Comment:
I'm handling this already in
https://github.com/apache/iceberg/pull/11254/commits/4d42f180a4597d274f331dd5abe32fd840611f69.
I just didn't want to introduce too many changes/refactorings as the PR is
already quite large
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
