nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793489743
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -215,7 +213,7 @@ private List<ManifestFile> writeNewManifests() throws
IOException {
}
if (newManifests == null && !newFiles.isEmpty()) {
- this.newManifests = writeDataManifests(newFiles, spec);
+ this.newManifests = writeDataManifests(Lists.newArrayList(newFiles),
spec);
Review Comment:
no objection to that. I'll do the same for `writeDeleteManifests`since we'll
need that too in the next PR (https://github.com/apache/iceberg/pull/11254)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
