rdsr commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r472532591
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -51,6 +58,17 @@
forwardConfigSettings(job);
+ //Convert Hive filter to Iceberg filter
+ String hiveFilter = job.get(TableScanDesc.FILTER_EXPR_CONF_STR);
Review comment:
I don't think `getSplits` is the right method to set the translated
Iceberg expr in jobconf. I think this should go in `IcebergStorageHandler` .
@guilload what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
