massdosage commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r472991930
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -51,6 +58,17 @@
forwardConfigSettings(job);
Review comment:
> rebase
Shouldn't we be following the [Golden Rule of
Rebasing](https://www.atlassian.com/git/tutorials/merging-vs-rebasing#the-golden-rule-of-rebasing)
and *not* do this on public branches? It has the potential to cause all kinds
of inconsistencies on other people's checkouts. Surely we should be doing
merge? It all gets squash merged at the end so having a pristine history isn't
worth the downsides of inconsistencies IHMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
