rdblue commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r473215871
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -51,6 +58,17 @@
forwardConfigSettings(job);
Review comment:
I think that either rebasing or merging master into a PR is okay.
As a reviewer, I don't really consider PR branches to be public because
github handles force-pushes well. If I have a PR checked out, I also don't mind
resetting to the PR's current state because I like keeping history clean.
That said, if you're sharing a PR branch between people that can be
disruptive, so I think it is up to the author and collaborators whether to
merge or to rebase to stay up to date with master.
Is that reasonable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
