omalley commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r473288060



##########
File path: 
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -51,6 +58,17 @@
 
     forwardConfigSettings(job);

Review comment:
       That sounds reasonable as long as the PR is rebased to master before it 
is committed. Having a linear history makes things much much easier to track 
where a change happened.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to