rdblue commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917410896
##########
core/src/test/java/org/apache/iceberg/TestDataTaskParser.java:
##########
@@ -193,10 +193,26 @@ private DataTask createDataTask() {
List<Snapshot> snapshots =
Arrays.asList(
- new BaseSnapshot(
- 1L, 1L, null, 1234567890000L, "append", summary1, 1,
"file:/tmp/manifest1.avro"),
- new BaseSnapshot(
- 2L, 2L, 1L, 9876543210000L, "append", summary2, 1,
"file:/tmp/manifest2.avro"));
+ MetadataTestUtils.buildTestSnapshot()
+ .setSequenceNumber(1L)
+ .setSnapshotId(1L)
+ .setParentId(null)
+ .setTimestampMillis(1234567890000L)
+ .setOperation("append")
+ .setSummary(summary1)
+ .setSchemaId(1)
+ .setManifestListLocation("file:/tmp/manifest1.avro")
+ .build(),
+ MetadataTestUtils.buildTestSnapshot()
+ .setSequenceNumber(2L)
+ .setSnapshotId(2L)
+ .setParentId(1L)
+ .setTimestampMillis(9876543210000L)
+ .setOperation("append")
+ .setSummary(summary2)
+ .setSchemaId(1)
+ .setManifestListLocation("file:/tmp/manifest2.avro")
+ .build());
Review Comment:
It doesn't seem to me that this strictly needs to be changed, but I'm okay
with it for readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
