rdblue commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917414530
##########
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##########
@@ -56,13 +56,16 @@ public void testJsonConversion() throws IOException {
@Test
public void testJsonConversionWithoutSchemaId() throws IOException {
- int snapshotId = 23;
- Long parentId = null;
- String manifestList = createManifestListWithManifestFiles(snapshotId,
parentId);
-
Snapshot expected =
- new BaseSnapshot(
- 0, snapshotId, parentId, System.currentTimeMillis(), null, null,
null, manifestList);
+ MetadataTestUtils.buildTestSnapshotWithExampleValues()
Review Comment:
Since this is used to fill base data and then the methods are used to
override, should example values be the default behavior? That would make more
sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
