RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917401890
##########
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##########
@@ -37,13 +34,16 @@ public class TestSnapshotJson {
@Test
public void testJsonConversion() throws IOException {
- int snapshotId = 23;
- Long parentId = null;
- String manifestList = createManifestListWithManifestFiles(snapshotId,
parentId);
-
Snapshot expected =
- new BaseSnapshot(
- 0, snapshotId, parentId, System.currentTimeMillis(), null, null,
1, manifestList);
+ MetadataTestUtils.buildTestSnapshotWithExampleValues()
+ .setOperation(null)
Review Comment:
I don't think operation, summary or schema ID really need to be specified
here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
