gaborkaszab commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1932459105
##########
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##########
@@ -84,6 +85,7 @@ private RESTClient httpClient() {
private LoadCredentialsResponse fetchCredentials() {
return httpClient()
+ .withAuthSession(AuthSession.EMPTY)
Review Comment:
I just took a quick look because I'm also working on the HttpClient code and
was curious about this PR.
This might have been commented, but wouldn't it be possible to pass the
AuthSession to the HttpClient during creation, maybe through a Builder? Then we
could avoid adding these 'withAuthSession' calls when we use the httpClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
