danielcweeks commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1942060653
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -192,6 +192,7 @@ private RESTClient httpClient() {
HTTPClient.builder(properties())
.uri(baseSignerUri())
.withObjectMapper(S3ObjectMapper.mapper())
+
.withAuthSession(org.apache.iceberg.rest.auth.AuthSession.EMPTY)
Review Comment:
Why are we setting this to EMPTY? In order to sign we need an auth session.
Wouldn't this result in no headers/sigs being produced if a call was made
without explicitly setting the auth session? We want enforce that an auth
session is used, but this results in falling back to nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
