adutra commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1942701609
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -192,6 +192,7 @@ private RESTClient httpClient() {
HTTPClient.builder(properties())
.uri(baseSignerUri())
.withObjectMapper(S3ObjectMapper.mapper())
+
.withAuthSession(org.apache.iceberg.rest.auth.AuthSession.EMPTY)
Review Comment:
I agree with your suggestions for other components, but here I disagree: the
HTTP client _must_ be configured with an empty auth session because it will be
used for token refreshes. If it contains, say, token `t1`, and token `t1` gets
refreshed and exchanged for `t2`, there would be a clash between the token from
the HTTP client (`t1`) and the one from the refreshed auth session (`t2`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
