aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1940041876
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -166,6 +169,10 @@ public static String toJson(Schema schema, boolean pretty)
{
private static Type typeFromJson(JsonNode json) {
if (json.isTextual()) {
+ if (VARIANT.equalsIgnoreCase(json.asText())) {
Review Comment:
From dev list discussion, seems we need to add new one and mark this one
deprecated. Then we will deprecate later. I added a new `fromTypeString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
