rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1942078866
##########
api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java:
##########
@@ -645,4 +647,37 @@ public void testReassignOrRefreshIdsCaseInsensitive() {
required(2, "FIELD2", Types.IntegerType.get())));
assertThat(actualSchema.asStruct()).isEqualTo(expectedSchema.asStruct());
}
+
+ @Test
+ public void testVariantType() {
Review Comment:
I think this should be more specific. Right now, it looks like all of the
methods that needed to be validated were added here (I see at least
`assignFreshIds` and `project`).
Instead, I think that this should locate a test case with each group of
tests (for the different `TestUtil` methods) and name it something like
`testProjectWithVariantType()` or `testAssignFreshIdsWithVariantType()`.
Another thing that would be nice is to add tests for `NewTypes` instead of
just Variant. You could parameterize them and test `TimestampNanoType`,
`UnknownType`, as well. (We can also do that in a follow up if you want).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
