rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1942088807
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -81,6 +82,16 @@ public static PrimitiveType fromPrimitiveString(String
typeString) {
throw new IllegalArgumentException("Cannot parse type string to primitive:
" + typeString);
}
+ @Deprecated
Review Comment:
Since this has a different return type, it makes sense to me that it would
be supported. I think the motivation to deprecate it is that we want uses to
move to `fromString` / `fromTypeName`, but we can do that by searching for uses
and updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
