ajantha-bhat commented on code in PR #12476:
URL: https://github.com/apache/iceberg/pull/12476#discussion_r1985386525
##########
core/src/main/java/org/apache/iceberg/InternalData.java:
##########
@@ -34,6 +34,21 @@
import org.slf4j.LoggerFactory;
public class InternalData {
+ /**
+ * An iterable returned by readers the also exposes access to the file
metadata.
Review Comment:
```suggestion
* An iterable returned by readers that also exposes access to the file
metadata.
```
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java:
##########
@@ -34,7 +35,7 @@
import org.apache.parquet.hadoop.ParquetFileReader;
import org.apache.parquet.schema.MessageType;
-public class ParquetReader<T> extends CloseableGroup implements
CloseableIterable<T> {
+public class ParquetReader<T> extends CloseableGroup implements
InternalData.DataIterable<T> {
Review Comment:
Changes in the Parquet should be in another PR? as the PR title says just
replace Avro generic with Avro internal data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
