rdblue commented on code in PR #12476:
URL: https://github.com/apache/iceberg/pull/12476#discussion_r1985848527
##########
core/src/main/java/org/apache/iceberg/InternalData.java:
##########
@@ -163,6 +180,11 @@ public interface ReadBuilder {
/** Set a custom class for in-memory objects at the given field ID. */
ReadBuilder setCustomType(int fieldId, Class<? extends StructLike>
structClass);
+ /** Set the classloader used for custom types. */
+ default ReadBuilder classLoader(ClassLoader classLoader) {
+ throw new UnsupportedOperationException("Classloader not supported");
Review Comment:
I don't think that this is needed. I originally added it in the InternalData
commit, but because we are passing the classes themselves (rather than loading
them dynamically by name) they are already loaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
