danielcweeks commented on code in PR #12476:
URL: https://github.com/apache/iceberg/pull/12476#discussion_r1985436472
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java:
##########
@@ -34,7 +35,7 @@
import org.apache.parquet.hadoop.ParquetFileReader;
import org.apache.parquet.schema.MessageType;
-public class ParquetReader<T> extends CloseableGroup implements
CloseableIterable<T> {
+public class ParquetReader<T> extends CloseableGroup implements
InternalData.DataIterable<T> {
Review Comment:
It's pulling an abstraction from Avro to the InternalData, which applies to
Avro and Parquet. However, this impacts revapi, so possibly need see if
there's a way to cleanly evolve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
