adutra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1993770830
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -81,25 +85,25 @@ public OAuth2Util.AuthSession initSession(RESTClient
initClient, Map<String, Str
this.startTimeMillis = System.currentTimeMillis();
this.authResponse =
OAuth2Util.fetchToken(
- initClient,
- headers,
+ initClient.withAuthSession(session),
+ Map.of(),
config.credential(),
config.scope(),
config.oauth2ServerUri(),
config.optionalOAuthParams());
return OAuth2Util.AuthSession.fromTokenResponse(
- initClient, null, authResponse, startTimeMillis, session);
+ null, null, authResponse, startTimeMillis, session);
Review Comment:
I was just trying to. make it clear that the token endpoint wouldn't be
contacted in this case. I will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
