adutra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1996148530
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -96,45 +98,10 @@ public static void beforeClass() throws Exception {
if (null == httpServer) {
httpServer = initHttpServer();
}
-
- validatingSigner =
- new ValidatingSigner(
- ImmutableS3V4RestSignerClient.builder()
- .properties(
- ImmutableMap.of(
- S3V4RestSignerClient.S3_SIGNER_URI,
- httpServer.getURI().toString(),
- OAuth2Properties.CREDENTIAL,
- "catalog:12345"))
- .build(),
- new CustomAwsS3V4Signer());
}
@AfterAll
public static void afterClass() throws Exception {
- assertThat(validatingSigner.icebergSigner.tokenRefreshExecutor())
- .isInstanceOf(ScheduledThreadPoolExecutor.class);
-
- ScheduledThreadPoolExecutor executor =
- ((ScheduledThreadPoolExecutor)
validatingSigner.icebergSigner.tokenRefreshExecutor());
- // token expiration is set to 10000s by the S3SignerServlet so there
should be exactly one token
- // scheduled for refresh. Such a high token expiration value is explicitly
selected to be much
- // larger than TestS3RestSigner would need to execute all tests.
- // The reason why this check is done here with a high token expiration is
to make sure that
- // there aren't other token refreshes being scheduled after every sign
request and after
- // TestS3RestSigner completes all tests, there should be only this single
token in the queue
- // that is scheduled for refresh
Review Comment:
@nastra you are 100% right here, I was a bit too heavy-handed when I removed
this piece of code. I put it back almost like it was before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
