nastra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1995619212
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -81,13 +77,14 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
@SuppressWarnings("immutables:incompat")
- private static volatile ScheduledExecutorService tokenRefreshExecutor;
+ private volatile AuthManager authManager;
Review Comment:
related to my other comment from
https://github.com/apache/iceberg/pull/12197/files#r1993040250 I currently
don't know whether having this field being non-static would cause what was
earlier tested in
https://github.com/apache/iceberg/pull/12197/files#r1993040250. My current
guess is that the code you currently have here will work, but we'll know for
sure once we have the tests in place that I mentioned in the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
