zratkai commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r2020810631
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -1048,7 +1048,7 @@ public void testSetSnapshotSummary() throws Exception {
@Test
public void testNotExposeTableProperties() {
Configuration conf = new Configuration();
- conf.set("iceberg.hive.table-property-max-size", "0");
+ final long maxHiveTablePropertySize = 0;
HiveTableOperations ops =
new HiveTableOperations(conf, null, null, catalog.name(), DB_NAME,
"tbl");
Review Comment:
Fixed.
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -1015,7 +1015,7 @@ public void testSnapshotStatsTableProperties() throws
Exception {
@Test
public void testSetSnapshotSummary() throws Exception {
Configuration conf = new Configuration();
- conf.set("iceberg.hive.table-property-max-size", "4000");
+ final long maxHiveTablePropertySize = 4000;
HiveTableOperations ops =
new HiveTableOperations(conf, null, null, catalog.name(), DB_NAME,
"tbl");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
