pvary commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r2026463958


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##########
@@ -175,11 +172,14 @@ public void doCommit(ViewMetadata base, ViewMetadata 
metadata) {
                 .filter(key -> !metadata.properties().containsKey(key))
                 .collect(Collectors.toSet());
       }
-
-      setHmsTableParameters(newMetadataLocation, tbl, metadata, removedProps);
-
+      HMSTablePropertyHelper.setHmsTableParameters(
+          newMetadataLocation,
+          tbl,
+          metadata,
+          removedProps,
+          maxHiveTablePropertySize,
+          currentMetadataLocation());
       lock.ensureActive();
-

Review Comment:
   Please revert this change - not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to