pvary commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r2026460106
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -230,12 +190,14 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
.collect(Collectors.toSet());
}
- Map<String, String> summary =
- Optional.ofNullable(metadata.currentSnapshot())
- .map(Snapshot::summary)
- .orElseGet(ImmutableMap::of);
- setHmsTableParameters(
- newMetadataLocation, tbl, metadata, removedProps, hiveEngineEnabled,
summary);
+ HMSTablePropertyHelper.setHmsTableParameters(
Review Comment:
Suggested an update for the name, so this name should change too
```suggestion
HMSTablePropertyHelper.updateHmsTableForIcebergTable(
```
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -230,12 +190,14 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
.collect(Collectors.toSet());
}
- Map<String, String> summary =
- Optional.ofNullable(metadata.currentSnapshot())
- .map(Snapshot::summary)
- .orElseGet(ImmutableMap::of);
- setHmsTableParameters(
- newMetadataLocation, tbl, metadata, removedProps, hiveEngineEnabled,
summary);
+ HMSTablePropertyHelper.setHmsTableParameters(
Review Comment:
Suggested an update for the name, so this line should change too
```suggestion
HMSTablePropertyHelper.updateHmsTableForIcebergTable(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
