lidavidm commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2115790873
##########
src/iceberg/expected.h:
##########
@@ -122,7 +122,7 @@ inline constexpr bool is_error_type_valid_v =
is_error_type_valid<T>::value;
} // namespace expected_detail
template <class E>
-class ICEBERG_EXPORT [[nodiscard]] unexpected {
Review Comment:
Hmm, if it works it works. I really don't get how the Windows model works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
