wgtmac commented on code in PR #113:
URL: https://github.com/apache/iceberg-cpp/pull/113#discussion_r2125320434
##########
src/iceberg/arrow/arrow_fs_file_io.h:
##########
@@ -46,6 +46,9 @@ class ICEBERG_BUNDLE_EXPORT ArrowFileSystemFileIO : public
FileIO {
/// \brief Delete a file at the given location.
Status DeleteFile(const std::string& file_location) override;
+ /// \brief Get the Arrow file system.
+ const std::shared_ptr<::arrow::fs::FileSystem>& fs() const { return
arrow_fs_; }
Review Comment:
@Fokko We have two libraries: `libiceberg` and `libiceberg-bundle`:
- libiceberg: it only uses interfaces of `FileIO` and `FileReader`,
downstream projects should provide their own implementations.
- libiceberg-bundle: it uses `ArrowFileSystemFileIO` as the implementation
and both Avro and Parquet reader implementations assume that arrow::FileSystem
is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
