mapleFU commented on PR #113: URL: https://github.com/apache/iceberg-cpp/pull/113#issuecomment-2934673162
Personally I prefer set a internal `status_` when error happens, and when `Next` is called, internal `status_` is checked before doing operations. Since this is generally a batch interface, this would not harm the performance and making using reader more robustness. However, current impl also lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
