nandorKollar commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2129051036
##########
gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java:
##########
@@ -70,6 +75,16 @@ public class GCSFileIOTest {
private final Storage storage =
spy(LocalStorageHelper.getOptions().getService());
private GCSFileIO io;
+ private static <T> Stream<Arguments> serializers() {
Review Comment:
Okay, we can do that sure, then the set of serialisers that we test against
will be fix for each test. I didn't include the spark modules yet, there's
still many such cases where we can refactor to parametrised tests, but I'm
afraid then the PR would become a bit too large.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
