nastra commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2131612553
##########
core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java:
##########
@@ -143,24 +145,17 @@ public void testDeleteFilesErrorHandling() {
.hasMessage("Failed to delete 2 files");
}
- @Test
- public void testHadoopFileIOKryoSerialization() throws IOException {
- FileIO testHadoopFileIO = new HadoopFileIO();
-
- // hadoop fileIO should be serializable when properties are passed as
immutable map
- testHadoopFileIO.initialize(ImmutableMap.of("k1", "v1"));
- FileIO roundTripSerializedFileIO =
TestHelpers.KryoHelpers.roundTripSerialize(testHadoopFileIO);
+ @ParameterizedTest
+ @MethodSource("org.apache.iceberg.TestHelpers#serializers")
+ public void testHadoopFileIOSerialization(
+ TestHelpers.RoundTripSerializer<FileIO> roundTripSerializer)
+ throws IOException, ClassNotFoundException {
-
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testHadoopFileIO.properties());
- }
-
- @Test
- public void testHadoopFileIOJavaSerialization() throws IOException,
ClassNotFoundException {
FileIO testHadoopFileIO = new HadoopFileIO();
// hadoop fileIO should be serializable when properties are passed as
immutable map
testHadoopFileIO.initialize(ImmutableMap.of("k1", "v1"));
Review Comment:
same as I mentioned in an earlier comment about using 2 key/value pairs
during testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
