nastra commented on code in PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#discussion_r2131615711
##########
gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java:
##########
@@ -202,24 +204,17 @@ public void testDeletePrefix() {
.isEqualTo(1);
}
- @Test
- public void testGCSFileIOKryoSerialization() throws IOException {
- FileIO testGCSFileIO = new GCSFileIO();
-
- // gcs fileIO should be serializable when properties are passed as
immutable map
- testGCSFileIO.initialize(ImmutableMap.of("k1", "v1"));
- FileIO roundTripSerializedFileIO =
TestHelpers.KryoHelpers.roundTripSerialize(testGCSFileIO);
-
-
assertThat(testGCSFileIO.properties()).isEqualTo(roundTripSerializedFileIO.properties());
- }
+ @ParameterizedTest
+ @MethodSource("org.apache.iceberg.TestHelpers#serializers")
+ public void testGCSFileIOSerialization(
+ TestHelpers.RoundTripSerializer<FileIO> roundTripSerializer)
+ throws IOException, ClassNotFoundException {
- @Test
- public void testGCSFileIOJavaSerialization() throws IOException,
ClassNotFoundException {
FileIO testGCSFileIO = new GCSFileIO();
// gcs fileIO should be serializable when properties are passed as
immutable map
testGCSFileIO.initialize(ImmutableMap.of("k1", "v1"));
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
