nastra commented on PR #13244:
URL: https://github.com/apache/iceberg/pull/13244#issuecomment-2949106755
> > thanks @nandorKollar, this looks great!
>
> @nastra I still missed one class, `TestTableSerialization`, where I got a
bit confused.
>
> I found a test like this one:
>
> ```
> @Test
> public void testSerializableTableWithSnapshot() throws IOException,
ClassNotFoundException {
> table.newAppend().appendFile(FILE_A).commit();
> TestHelpers.assertSerializedAndLoadedMetadata(table,
TestHelpers.roundTripSerialize(table));
> Table serializableTable = SerializableTable.copyOf(table);
> TestHelpers.assertSerializedAndLoadedMetadata(
> serializableTable,
TestHelpers.KryoHelpers.roundTripSerialize(serializableTable));
> }
> ```
>
> Do you happen to know, why the first one
`TestHelpers.assertSerializedAndLoadedMetadata(table,
TestHelpers.roundTripSerialize(table))` serializes the original table, but the
second case the Serializable copy of it?
>
> Does it make sense to test for the original table's serialisation? That
one will fail for Kryo.
I just realized that we don't need to do anything for
`TestTableSerialization`. The test first uses Java ser/de for the `table` which
is not a `SerializableTable`, hence it's expected that it fails with Kryo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
