rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229661680


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/SparkPlannedAvroReader.java:
##########
@@ -126,6 +126,11 @@ public ValueReader<?> map(Type partner, Schema map, 
ValueReader<?> valueReader)
       return SparkValueReaders.map(SparkValueReaders.strings(), valueReader);
     }
 
+    public ValueReader<?> variant(
+        Type partner, ValueReader<?> metadataReader, ValueReader<?> 
valueReader) {
+      return ValueReaders.variants();

Review Comment:
   With this and the fix for `TestHelpers.assertEquals`, the 
`TestParquetDataFrameWrite` suite passes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to